Merged
Conversation
- Add Select interface and SimpleSelect implementation - Add NativeSelectWrapper for native select support - Add hasSelect() and getSelect() to Query - Add selectBy() method to QueryBuilder (renamed from select to avoid Jackson conflict) - Add findAllProjected() method to Querity interface with default implementation - Implement projection support in JPA module (JpaSelect, JpaSimpleSelect, JpaQueryFactory) - Implement projection support in MongoDB module (MongodbSelect, MongodbSimpleSelect, MongodbQueryFactory) - Implement projection support in Elasticsearch module (ElasticsearchSelect, ElasticsearchSimpleSelect, ElasticsearchQueryFactory) - Add SELECT keyword to parser grammar - Add SelectUtils for native select wrapper resolution - Add tests for select in spring-web module Note: Using SimpleSelect (concrete class) instead of Select (interface) in Query to avoid Jackson deserialization issues with polymorphic types.
- Add SimpleSelectTest for API module - Add JpaSelectTests for JPA module - Add parser tests for SELECT keyword in QuerityParserTests
- Create SelectDeserializer following the same pattern as ConditionDeserializer - Register SelectDeserializer in QuerityModule - Change Query.select from SimpleSelect to Select interface - Add getPropertyNames() method to Select interface - Update JpaSelect, MongodbSelect, ElasticsearchSelect to accept Select interface - Update QueryVisitor to use Select interface This approach is more consistent with how Condition is handled and allows for proper polymorphic deserialization of Select implementations.
- Create SortDeserializer following the same pattern as ConditionDeserializer and SelectDeserializer - Register SortDeserializer in QuerityModule - Remove @JsonTypeInfo/@JsonSubTypes annotations from Sort interface Now all three interfaces (Condition, Select, Sort) use custom deserializers registered in QuerityModule for consistent and predictable JSON parsing.
- Add NativeSelectWrapperTest for API module - Add DeserializerTests for SelectDeserializer and SortDeserializer - Add test for unsupported Select type in JpaSelectTests - Coverage improvements: - querity-api: 98% - querity-spring-web: 99% - querity-jpa-common: 78%
- Add DateValueExtractorTests for Date value extraction - Add SelectUtilsTests for NativeSelectWrapper handling - Add SpecificationTests for JPA Specification.where() - Add projection tests for Elasticsearch, MongoDB, and JPA - Add additional parser tests for edge cases - Fix DeserializerTests assertions for exception handling - Extend JpaSelectTests with NativeSelectWrapper tests - Configure JaCoCo to exclude ANTLR generated classes
Member
|
Hi @vage88sg1 , thanks for the contribution! Could you please add some integration tests? Tests for Thanks! |
- Add SelectTests to QuerityGenericTestSuite with tests for selectBy - Add SelectionSpecification interface for native JPA selection expressions - Add AliasedSelectionSpecification for selections with custom aliases - Add JpaSelectionSpecificationSelectWrapper for native select support - Add selectByNative tests with concat expression in JPA test classes - Add sortByNative test with expression (cb.length) in JPA test classes - Update README with documentation for projections and native expressions - Update JpaSelect interface to include CriteriaBuilder parameter 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
done |
Member
|
@vage88sg1 could you please take a look at the tests that are not passing? |
- givenSelectByTwoFields: relax lastName assertion (null values may be excluded from projections in MongoDB/Elasticsearch) - givenSelectByNestedField: accept both flat 'city' and nested 'address.city' structures (Elasticsearch returns nested structure) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
now should be ok |
brunomendola
reviewed
Dec 8, 2025
Member
brunomendola
left a comment
brunomendola
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I've added a few comments to guide you in the structure of the project, there is some code that could be better placed, but apart from that it's a neat PR! Well done!
...y-jpa-common/src/test/java/io/github/queritylib/querity/jpa/SpringH2QuerityJpaImplTests.java
Outdated
Show resolved
Hide resolved
...t/java/io/github/queritylib/querity/spring/data/jpa/SpringPostgresqlQuerityJpaImplTests.java
Outdated
Show resolved
Hide resolved
querity-test/src/main/java/io/github/queritylib/querity/test/QuerityGenericTestSuite.java
Outdated
Show resolved
Hide resolved
- Relocate selectByNative tests from SpringPostgresqlQuerityJpaImplTests to QuerityJpaImplTests - Tests validate SQL database behavior generally, not Postgres-specific edge cases - Enhance givenSelectByTwoFields test with lastName IS_NOT_NULL filter - Restore lastName containsKey assertion for more robust validation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.